Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper: Additional paper edits #2590

Merged
merged 6 commits into from
Jan 4, 2025
Merged

paper: Additional paper edits #2590

merged 6 commits into from
Jan 4, 2025

Conversation

jackiekazil
Copy link
Member

@jackiekazil jackiekazil commented Jan 3, 2025

I am going through making some polishing adjustments on the paper -- I bucketed a bunch of commits because they are minor. (There might be a PR or two after this -- I wanted to break it up a little).

Let me know if you have any questions.

Related ticket #2559

@jackiekazil jackiekazil requested a review from EwoutH January 3, 2025 06:23
@jackiekazil jackiekazil changed the base branch from main to paper_2024 January 3, 2025 06:24
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these look good!

@EwoutH EwoutH requested a review from quaquel January 3, 2025 06:57
@jackiekazil jackiekazil merged commit 4dddba6 into paper_2024 Jan 4, 2025
11 of 12 checks passed
@jackiekazil
Copy link
Member Author

I noticed the @quaquel request after I merged... @quaquel --- I am still doing a final review of the paper. Let me know if you want something adjusted, and I can adjust in an additional PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants