Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Render agent marker radius correctly #2181

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jul 14, 2024

Previously, on a 2x20 Schelling grid (extremely tall on the vertical direction, but thin on horizontal direction)
before
With this PR
after

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +1.5% [+0.7%, +2.2%] 🔵 +2.5% [+2.1%, +3.0%]
Schelling large 🔵 +1.0% [-0.4%, +2.6%] 🔵 +1.4% [+0.5%, +2.4%]
WolfSheep small 🔵 +0.2% [-1.5%, +1.9%] 🔵 -0.0% [-0.9%, +0.8%]
WolfSheep large 🔵 -0.3% [-1.6%, +1.1%] 🔵 -0.4% [-1.2%, +0.5%]
BoidFlockers small 🔵 -0.7% [-2.9%, +1.3%] 🔵 -0.0% [-0.6%, +0.6%]
BoidFlockers large 🔵 +0.6% [-1.4%, +3.0%] 🔵 +0.6% [-0.3%, +1.5%]

@tpike3 tpike3 merged commit d2348e2 into projectmesa:main Jul 20, 2024
10 of 12 checks passed
@rht rht deleted the matplotlib_viz_bug branch July 20, 2024 11:00
@EwoutH EwoutH added the bug Release notes label label Jul 22, 2024
@EwoutH
Copy link
Member

EwoutH commented Jul 22, 2024

Should this be backported to 2.3?

@rht
Copy link
Contributor Author

rht commented Jul 22, 2024

Yeah, sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants