-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve flocking benchmark #2054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance benchmarks:
|
Performance benchmarks:
|
rht
reviewed
Feb 25, 2024
@@ -136,15 +137,15 @@ def make_agents(self): | |||
x = self.random.random() * self.space.x_max | |||
y = self.random.random() * self.space.y_max | |||
pos = np.array((x, y)) | |||
velocity = np.random.random(2) * 2 - 1 | |||
direction = np.random.random(2) * 2 - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw the docstring says "headings" and this needs to be replaced with "directions" as well.
@coderbeta1 thank you for the needed corrections and improvements to the examples so far. |
rht
approved these changes
Feb 26, 2024
quaquel
pushed a commit
to quaquel/mesa
that referenced
this pull request
Apr 9, 2024
* Improve flocking * Update flocking.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
self.velocity
toself.direction
: Both Velocity and Speed are agent attributes. This leads to unnecessary confusion. So I changedvelocity
todirection
seed
value. This allows for easy randomness if needed.