-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiscreteEventScheduler #1890
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fd8e979
Add DiscreteEventScheduler
EwoutH 09b517f
DiscreteEventScheduler: Add schedule_in function
EwoutH 0be8be4
DiscreteEventScheduler: Add type hints, check for negative, include e…
EwoutH 7dc042c
DiscreteEventScheduler: Add schedule_now keyword argument to add()
EwoutH eafebda
Add tests for DiscreteEventScheduler
EwoutH c22eb89
Fix two ruff checks
EwoutH 1f6de65
DiscreteEventScheduler: Use model.random instead of random
EwoutH ce89b21
test_time: Sort imports for ruff
EwoutH 1643c62
DiscreteEventScheduler: Black formatting
EwoutH adbf7de
DiscreteEventScheduler: Clean up docstring a bit
EwoutH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been clearer to say that the
random_value
is used only once for theheapq.push
operation. I had to check elsewhere in the code for its usage, until I realized of this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read it for again, I think it’s quite clear, especially together with the comments lower in the code..