Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove dict merge operator, python 3.8 compat #1793

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

Corvince
Copy link
Contributor

@Corvince Corvince commented Sep 7, 2023

Fixed Python 3.8 compatibility

It turns out that there is a failed CI test on Python 3.8. I didn't realize it happening because I'm used to the coverage often giving "x". The reason is that | is not supported on 3.8.

Originally posted by @rht in #1788 (comment)

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d451ef0) 82.05% compared to head (30369fe) 82.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1793   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files          15       15           
  Lines         886      886           
  Branches      191      191           
=======================================
  Hits          727      727           
  Misses        135      135           
  Partials       24       24           
Files Changed Coverage Δ
mesa/experimental/jupyter_viz.py 35.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@rht rht merged commit 20dbf9e into main Sep 8, 2023
@rht rht deleted the fix-py38-compat branch September 8, 2023 02:00
@tpike3 tpike3 added this to the Release 2.1.2 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants