Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce mesa.models #1700

Closed
wants to merge 1 commit into from
Closed

Conversation

rht
Copy link
Contributor

@rht rht commented May 16, 2023

Addresses #1228.
This is so that people can easily reuse these canned models, for experimentation, classroom demo, etc.
For now, it contains only boltzmann_wealth_model.

@rht rht force-pushed the canned_models branch from 88dfdb8 to 2f6cc92 Compare May 16, 2023 12:42
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 65.21% and project coverage change: -0.52 ⚠️

Comparison is base (68b8e6c) 81.49% compared to head (af8bc85) 80.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   81.49%   80.97%   -0.52%     
==========================================
  Files          18       19       +1     
  Lines        1405     1451      +46     
  Branches      273      279       +6     
==========================================
+ Hits         1145     1175      +30     
- Misses        214      230      +16     
  Partials       46       46              
Impacted Files Coverage Δ
mesa/models/boltzmann_wealth_model.py 65.21% <65.21%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rht rht force-pushed the canned_models branch from 2f6cc92 to 323d1aa Compare May 16, 2023 12:48
This is so that people can easily reuse these canned models, for
experimentation, classroom demo, etc.
For now, it contains only boltzmann_wealth_model.
@tpike3
Copy link
Member

tpike3 commented May 17, 2023

This is awesome! I see where you are going with this. Would we want to put mesa.models in mesa folder or do it as part of examples? The idea being there would be a library called mesa_models so if they wanted to demo they could just install the mesa_models library which would alleviate the duplication complication](#1698 (comment)) and then this would be a subset of mesa-examples. What do you think?

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@rht
Copy link
Contributor Author

rht commented May 17, 2023

mesa-examples would be fine only if select a subset of the examples to be in the Python package. Some of the GIS examples have data files that would make the wheel large, though won't get to 50 MB large. The problem is that then we will have to maintain one more additional PyPI package.

@rht
Copy link
Contributor Author

rht commented May 17, 2023

I suppose maintaining one more PyPI package is less cumbersome than maintaining copies of the examples.

@ankitk50
Copy link
Contributor

I suppose maintaining one more PyPI package is less cumbersome than maintaining copies of the examples.

And later of course we will keep adding more examples to the package.

@rht
Copy link
Contributor Author

rht commented May 17, 2023

Superseded by projectmesa/mesa-examples#35

@rht rht closed this May 17, 2023
@rht rht deleted the canned_models branch May 17, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants