-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce mesa.models #1700
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
- Coverage 81.49% 80.97% -0.52%
==========================================
Files 18 19 +1
Lines 1405 1451 +46
Branches 273 279 +6
==========================================
+ Hits 1145 1175 +30
- Misses 214 230 +16
Partials 46 46
☔ View full report in Codecov by Sentry. |
This is so that people can easily reuse these canned models, for experimentation, classroom demo, etc. For now, it contains only boltzmann_wealth_model.
This is awesome! I see where you are going with this. Would we want to put mesa.models in mesa folder or do it as part of examples? The idea being there would be a library called mesa_models so if they wanted to demo they could just install the mesa_models library which would alleviate the duplication complication](#1698 (comment)) and then this would be a subset of mesa-examples. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
mesa-examples would be fine only if select a subset of the examples to be in the Python package. Some of the GIS examples have data files that would make the wheel large, though won't get to 50 MB large. The problem is that then we will have to maintain one more additional PyPI package. |
I suppose maintaining one more PyPI package is less cumbersome than maintaining copies of the examples. |
And later of course we will keep adding more examples to the package. |
Superseded by projectmesa/mesa-examples#35 |
Addresses #1228.
This is so that people can easily reuse these canned models, for experimentation, classroom demo, etc.
For now, it contains only boltzmann_wealth_model.