Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename altair.py and matplotlib.py #2434

Closed
quaquel opened this issue Oct 30, 2024 · 2 comments · Fixed by #2447
Closed

rename altair.py and matplotlib.py #2434

quaquel opened this issue Oct 30, 2024 · 2 comments · Fixed by #2447

Comments

@quaquel
Copy link
Member

quaquel commented Oct 30, 2024

The naming of mesa.visualization.components.altair and mesa.visualization.components.matplotlib can cause namespace clashes. They thus need to be renamed to e.g., altair_components and matplotlib_components.

@Corvince
Copy link
Contributor

Also note that I would suggest the naming "component" to refer to solara components specifically. But we now also provide general drawing functions that return matplotlib figures, so the file name is outdated and should be reconsidered more generally

@quaquel
Copy link
Member Author

quaquel commented Oct 30, 2024

It might then make sense to move the draw_space and draw_x functions into their own module (e.g., space_drawing) and leave the solara specific stuff in matplotlib_components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants