You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The first parameter of all tests with loggers on records is wrong.
This happens because lombok adds the generated logger field as first child but eclipse expects that the record components are the first fields. I don't think that this affects the actual compilation result.
I also noticed that the output is different in recent eclipse versions, we may need to introduce a new directive to handle that.
Yup, eclipse belatedly fixing their prettyprinter is rather annoying. An alternative solution is that we take the current eclipse pretty printer which is pretty nice, and include it directly in the lombok test suite, so that we always use this (instead of 'whatever the prettyprinter is that ships with the ecj/eclipse version we are testing right now), and thus avoid having to add more directives.
Describe the bug
The first parameter of all tests with loggers on records is wrong.
This happens because lombok adds the generated logger field as first child but eclipse expects that the record components are the first fields. I don't think that this affects the actual compilation result.
I also noticed that the output is different in recent eclipse versions, we may need to introduce a new directive to handle that.
To Reproduce
lombok/test/transform/resource/after-ecj/LoggerSlf4jOnRecord.java
Line 3 in c99e6bb
Expected behavior
The generated compact construct only contains the record components.
The text was updated successfully, but these errors were encountered: