Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: Windows Exec support and Safe Mode #24

Merged
merged 2 commits into from
Nov 17, 2022
Merged

exec: Windows Exec support and Safe Mode #24

merged 2 commits into from
Nov 17, 2022

Conversation

tarunKoyalwar
Copy link
Member

Description

  • Adds support for command execution in Windows
  • API CHANGE
Adds:
 RunPS(cmd ...string) // Run Command in Windows
 RunSafe(cmd ...string) // Run Command without using os shell with limited features
Update:
 Run(cmd ...string)  // Now supports Pipe(|) , redirection (> << & etc) along with other shell features
  • Adds Appropriate Unit Tests

@tarunKoyalwar tarunKoyalwar self-assigned this Nov 17, 2022
@Mzack9999 Mzack9999 linked an issue Nov 17, 2022 that may be closed by this pull request
executils should identify CLI engine to invoke on windows #15
Closed
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review November 17, 2022 10:10
@tarunKoyalwar tarunKoyalwar added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 17, 2022
Mzack9999
Mzack9999 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mzack9999 Mzack9999 merged commit 45159c4 into main Nov 17, 2022
@Mzack9999 Mzack9999 deleted the issue-15-exec-winsupport branch November 17, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executils should identify CLI engine to invoke on windows
2 participants
@tarunKoyalwar @Mzack9999