changed warning to error if the directory does not have write permission #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
$ mkdir dir_no_write
$ chmod 400 dir_no_write/
$ touch dir_no_write/test.txt
touch: dir_no_write/test.txt: Permission denied
$ echo 'example.com' | go run . -store-response-dir ./dir_no_write/
__ __ __ _ __
/ /_ / /_/ /_____ | |/ /
/ __ \/ __/ __/ __ \| /
/ / / / /_/ /_/ /_/ / |
/_/ /_/\__/\__/ .___/_/|_|
/_/ v1.2.1
projectdiscovery.io
Use with caution. You are responsible for your actions.
Developers assume no liability and are not responsible for any misuse or damage.
[ERR] Could not write response at path 'dir_no_write/example.com.txt', to disk: open dir_no_write/example.com.txt: permission denied
https://example.com
ehsandeep
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays an error if the user attempts to store response in a directory with no write permission.
Test: Create a directory without write permission, run echo 'example.com' | ./httpx -store-response-dir ./no_write_permission_dir/