Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cname with ports flag bug-fix #625

Merged
merged 1 commit into from
May 17, 2022
Merged

cname with ports flag bug-fix #625

merged 1 commit into from
May 17, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented May 16, 2022 •
edited
Loading

This PR fixes a bug where cname is not displayed with ports flag.
Test: ./httpx -silent -cname -ports 80,443 -l list.txt

@LuitelSamikshya LuitelSamikshya self-assigned this May 16, 2022
@LuitelSamikshya LuitelSamikshya linked an issue May 16, 2022 that may be closed by this pull request
CNAME not displayed with -ports flag #604
Closed
@LuitelSamikshya LuitelSamikshya added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 16, 2022
@LuitelSamikshya LuitelSamikshya requested a review from Mzack9999 May 16, 2022 21:19
@Mzack9999 Mzack9999 mentioned this pull request May 17, 2022
Closed
@Mzack9999 Mzack9999 added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 17, 2022
ehsandeep
ehsandeep previously requested changes May 17, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per changes suggested by @Mzack9999

@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels May 17, 2022
@Mzack9999 Mzack9999 requested review from ehsandeep and removed request for Mzack9999 May 17, 2022 12:08
@ehsandeep ehsandeep merged commit f75729c into dev May 17, 2022
@ehsandeep ehsandeep deleted the issue-604-cname-not-displayed-with-ports-flag branch May 17, 2022 16:20
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNAME not displayed with -ports flag
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999