-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match/filter response time #597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LuitelSamikshya,
Could you please include an example using response-based matcher/filter? also we can include the time unit used with matcher/filter in CLI flag description, which supposed to be in second in this case.
chaos -d hackerone.com | ./httpx -mrt '> 1' -silent
[FTL] invalid value provided for -mrt, -match-response-time
Sure, here are some examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further improvements:
- Use
https://github.com/dustin/go-humanize
to express units (eg2s
,200ms
) - Add tests
This PR adds flags
match-response-time / mrt
andfilter-response-time / frt
Example: