-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 549 jarm algorithm #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LuitelSamikshya
commented
Apr 5, 2022
•
edited by ehsandeep
Loading
edited by ehsandeep
ehsandeep
previously requested changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- removing debug output in result
- removing default value for the cases jarm hash can not be calculated.
Current:
echo www.hackerone.com | ./httpx -p 80 -hash jarm -silent
{www.hackerone.com 80 0 <nil>} http://www.hackerone.com:80
http://www.hackerone.com [00000000000000000000000000000000000000000000000000000000000000]
Expected:
echo www.hackerone.com | ./httpx -p 80 -hash jarm -silent
http://www.hackerone.com []
Mzack9999
previously requested changes
Apr 6, 2022
Mzack9999
reviewed
Apr 6, 2022
Mzack9999
requested changes
Apr 7, 2022
|
ehsandeep
approved these changes
Apr 8, 2022
SonarCloud Quality Gate failed. |
Mzack9999
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
Type: Enhancement
Most issues will probably ask for additions or changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.