Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat flag timer #504

Merged
merged 1 commit into from
Jan 20, 2022
Merged

stat flag timer #504

merged 1 commit into from
Jan 20, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Jan 20, 2022

This PR fixes duration calculation with the stats flag

@LuitelSamikshya LuitelSamikshya self-assigned this Jan 20, 2022
@LuitelSamikshya LuitelSamikshya linked an issue Jan 20, 2022 that may be closed by this pull request
@LuitelSamikshya LuitelSamikshya added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 20, 2022
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ echo 192.168.1.0/24 | go run . -stats -rl 1
...
[0:00:05] | RPS: 0 | Requests: 3 | Hosts: 51/256 (19%)
[0:00:10] | RPS: 0 | Requests: 7 | Hosts: 51/256 (19%)
[0:00:15] | RPS: 0 | Requests: 12 | Hosts: 51/256 (19%)
[0:00:20] | RPS: 0 | Requests: 16 | Hosts: 51/256 (19%)
[0:00:25] | RPS: 0 | Requests: 21 | Hosts: 51/256 (19%)
[0:00:30] | RPS: 0 | Requests: 25 | Hosts: 51/256 (19%)

@Mzack9999 Mzack9999 requested a review from ehsandeep January 20, 2022 06:52
@ehsandeep ehsandeep merged commit 58ef963 into dev Jan 20, 2022
@ehsandeep ehsandeep deleted the stat-flag-timer branch January 20, 2022 09:47
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-stats flag timer broken
3 participants