Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CDN Name in output and json #499

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Expose CDN Name in output and json #499

merged 3 commits into from
Feb 7, 2022

Conversation

Ice3man543
Copy link
Member

No description provided.

@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 15, 2022
@Ice3man543 Ice3man543 linked an issue Jan 15, 2022 that may be closed by this pull request
enhance cdn flag to return cdn name instead of boolean result #492
Closed
ehsandeep
ehsandeep requested changes Jan 16, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

echo https://www.hackerone.com | ./httpx -silent -cdn

https://www.hackerone.com [projectdiscovery]

@brenocss
Copy link

brenocss commented Jan 19, 2022 •
edited
Loading

The cdn field in json shouldn't be omitted when false. #496

"cdn": false

@Ice3man543 Ice3man543 self-assigned this Jan 23, 2022
@ehsandeep ehsandeep requested a review from Mzack9999 February 7, 2022 11:47
@ehsandeep ehsandeep merged commit 09b278b into dev Feb 7, 2022
@ehsandeep ehsandeep deleted the cdn-name-expose branch February 7, 2022 13:48
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhance cdn flag to return cdn name instead of boolean result
4 participants
@Ice3man543 @brenocss @ehsandeep @Mzack9999