Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CLI option to trim default HTTP/HTTPS ports from Host header #471

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Adding CLI option to trim default HTTP/HTTPS ports from Host header #471

merged 3 commits into from
Jan 4, 2022

Conversation

Mzack9999
Copy link
Member

This PR adds the -leave-default-ports CLI option. If specified, avoid trimming :80 for HTTP and :443 for HTTPS from the Host header

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 3, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 3, 2022
@Mzack9999 Mzack9999 linked an issue Jan 3, 2022 that may be closed by this pull request
httpx specifices :80 and :443 in the Host header, causing false negatives #464
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 3, 2022
LuitelSamikshya
LuitelSamikshya approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ehsandeep
ehsandeep requested changes Jan 4, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature seems to be supported already for port 80,443 with the default run but not when using ports flag, we can extend the default support with ports flag to cover this case.

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 4, 2022
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Jan 4, 2022
@ehsandeep ehsandeep merged commit 4791560 into dev Jan 4, 2022
@ehsandeep ehsandeep deleted the issue-464-default-ports branch January 4, 2022 09:35
@ehsandeep ehsandeep mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpx specifices :80 and :443 in the Host header, causing false negatives
3 participants
@Mzack9999 @ehsandeep @LuitelSamikshya