Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stop-resume support #345

Merged
merged 4 commits into from
Aug 7, 2021
Merged

Adding stop-resume support #345

merged 4 commits into from
Aug 7, 2021

Conversation

Mzack9999
Copy link
Member

No description provided.

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 6, 2021
@Mzack9999 Mzack9999 self-assigned this Aug 6, 2021
@Mzack9999 Mzack9999 linked an issue Aug 6, 2021 that may be closed by this pull request
[Feature] pause / resume ongoing scan #219
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Aug 6, 2021
ehsandeep
ehsandeep approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is working as expected.

Minor update:- we can include information similar to dnsx upon scan cancellation and resume.

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Aug 7, 2021
@Mzack9999 Mzack9999 merged commit a657905 into dev Aug 7, 2021
@Mzack9999 Mzack9999 deleted the 219-feature-stop-resume branch August 7, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] pause / resume ongoing scan
2 participants
@Mzack9999 @ehsandeep