Introducing CanHaveTitleTag Function for MIME Type Validation #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.3...v1.3.7) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1531) Bumps [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) from 0.37.4 to 0.37.7. - [Release notes](https://github.com/quic-go/quic-go/releases) - [Changelog](https://github.com/quic-go/quic-go/blob/master/Changelog.md) - [Commits](quic-go/quic-go@v0.37.4...v0.37.7) --- updated-dependencies: - dependency-name: github.com/quic-go/quic-go dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Hi! I noticed that some of the builds were failing with |
dogancanbakir
requested changes
Mar 7, 2024
dogancanbakir
requested changes
Mar 7, 2024
|
Once this is ready, I'll squash and open a new pull if you'd like, or we can keep it here. |
dogancanbakir
approved these changes
Mar 7, 2024
|
Thanks for the approval, would you like me to squash, or leave it? |
|
The latest commit shouldn't cause any issues, I updated the patch to match the code on the dev branch rather than the main branch. |
|
Hi, seeing as there are 11 commits for this, I feel like squashing might be wise, is that done during the merge process, or should I do it and re-open a pull? |
|
Hi, any update on this? |
Mzack9999
approved these changes
Mar 21, 2024
ehsandeep
approved these changes
Mar 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new function called
CanHaveTitleTag. The purpose of this function is to validate whether a given MIME type supports the extraction of a<title>tag from its content. The motivation behind this addition is to address issues where the extractor incorrectly assumes support for a<title>tag, even when it's not applicable, such as inapplication/jsonMIME types.Changes:
CanHaveTitleTagintitle.goto perform validation for MIME types supporting<title>tag extraction.runner.goto use the new functionNote
I'm not a frequent go developer, and this may be an ineffective way to achieve this goal, but from what I can tell, it gets the job done.