cname probe not work

[iflody]

In pr #108 seems that cname probe has been added, but when I try it locally it seems that not work,

Use the test case in the original pr:

https://www.hackerone.com
https://api.hackerone.com
https://mta-sts.hackerone.com
https://mta-sts.managed.hackerone.com
https://support.hackerone.com
https://mta-sts.forwarding.hackerone.com
https://docs.hackerone.com
https://resources.hackerone.com

./httpx -l domains.txt -cname

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/              v1.0.5

		projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
https://mta-sts.forwarding.hackerone.com
http://mta-sts.managed.hackerone.com
http://mta-sts.hackerone.com
http://api.hackerone.com
http://docs.hackerone.com
http://www.hackerone.com
http://resources.hackerone.com
http://support.hackerone.com

When I dig into source code I find that in internal/runner/runner.go:

dnsData, err := hp.Dialer.GetDNSData(domain)

and in fast dialer GetDNSData function:

		data, err = d.dnsclient.Resolve(hostname)
		if err != nil && d.options.EnableFallback {
			data, err = d.dnsclient.ResolveWithSyscall(hostname)
		}
		if err != nil {
			return nil, err
		}
		if data == nil {
			return nil, errors.New("could not resolve host")
		}
		b, _ := data.Marshal()
		err = d.hm.Set(hostname, b)
		if err != nil {
			return nil, err
		}
		return data, nil

It call retryabledns's Resolve function which only query for the A record:

func (c *Client) Resolve(host string) (*DNSData, error) {
	return c.Query(host, dns.TypeA)
}

So I think it is the root cause? I think the fastdialer need to add an function for A|CNAME type record.

[iflody]

I have make a pr projectdiscovery/fastdialer#11 , it is ugly but seems will work

[ehsandeep]

test $cat h1.txt 

https://www.hackerone.com
https://api.hackerone.com
https://mta-sts.hackerone.com
https://mta-sts.managed.hackerone.com
https://support.hackerone.com
https://mta-sts.forwarding.hackerone.com
https://docs.hackerone.com
https://resources.hackerone.com

test $cat h1.txt | httpx -silent -cname
https://docs.hackerone.com [hacker0x01.github.io]
https://mta-sts.managed.hackerone.com [hacker0x01.github.io]
https://mta-sts.hackerone.com [hacker0x01.github.io]
https://api.hackerone.com
https://support.hackerone.com [hackerone.zendesk.com]
https://resources.hackerone.com [read.uberflip.com]
https://www.hackerone.com
https://mta-sts.forwarding.hackerone.com [hacker0x01.github.io]

@iflody this works for me, I'm unable to reproduce this, on what system you running this, as per banner you are on the latest version of httpx.

[iflody]

Thanks for your reply, I try to clear my dns cache locally, and it just works, I can't repeat this bug again, sorry.

My system is MacOS Big Sur

[ehsandeep]

Np @iflody, thanks for confirming this, can we close this issue now and related PR?

[iflody]

Yes, I will do it.

[nvdadt]

-cname - does not work in latest build . Any work around for this ?

[nvdadt]

Thanks for the quick fix. From where do I get this latest build ?

[ehsandeep]

@nvdadt fix is merged into dev branch, you can pull dev branch with GO111MODULE=on go get -v github.com/projectdiscovery/httpx/cmd/httpx@dev before we create a new build.

[nvdadt]

Thanks @ehsandeep this worked. Please let me know when this goes to new build.

[ehsandeep]

@nvdadt this is now fixed in the latest release.