clarify logic in endpointstranslator.go

[xiangpingjiang]

fix #5800

[github-actions]

Hi @xiangpingjiang! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

[skriss]

commented re: unit test failures, cc @sunjayBhatia to check my logic here

[skriss]

@xiangpingjiang will you be able to address the failing unit tests here?

[xiangpingjiang]

@xiangpingjiang will you be able to address the failing unit tests here?

yes, I will do it this week

[sunjayBhatia]

left a comment on the open thread, seems like what @skriss suggested should work just fine, tested locally myself and with a few other options suggested all get the units to pass

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (13d0e36) 78.56% compared to head (4f74a4c) 78.69%.
Report is 59 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5927      +/-   ##
==========================================
+ Coverage   78.56%   78.69%   +0.12%     
==========================================
  Files         139      138       -1     
  Lines       19614    19719     +105     
==========================================
+ Hits        15410    15518     +108     
+ Misses       3901     3896       -5     
- Partials      303      305       +2     

Files	Coverage Δ
internal/xdscache/v3/endpointstranslator.go	88.64% <83.33%> (ø)
internal/xdscache/v3/endpointslicetranslator.go	82.31% <60.00%> (-0.60%)	⬇️

... and 34 files with indirect coverage changes

[skriss]

LGTM, thanks @xiangpingjiang