Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecosystem page #5537

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Add ecosystem page #5537

merged 8 commits into from
Nov 6, 2023

Conversation

izturn
Copy link
Member

@izturn izturn commented Jun 30, 2023

Signed-off-by: Gang Liu gang.liu@daocloud.io

fix #5280
fix #4704

Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn requested a review from a team as a code owner June 30, 2023 03:38
@izturn izturn requested review from stevesloka, skriss and sunjayBhatia and removed request for a team and stevesloka June 30, 2023 03:38
@izturn izturn added area/documentation Issues or PRs related to documentation. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #5537 (f1ac729) into main (5578185) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5537   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         139      139           
  Lines       19614    19614           
=======================================
  Hits        15410    15410           
  Misses       3901     3901           
  Partials      303      303           

@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2023
@izturn
Copy link
Member Author

izturn commented Jul 26, 2023

ping

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2023
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2023
@izturn
Copy link
Member Author

izturn commented Aug 29, 2023

ping

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2023
@tsaarni
Copy link
Member

tsaarni commented Aug 31, 2023

Just a question: was the conclusion in #5280 and #4704 to add an ecosystem web page on projectcontour.io?

@izturn
Copy link
Member Author

izturn commented Aug 31, 2023

i think so

@tsaarni
Copy link
Member

tsaarni commented Aug 31, 2023

If aiming for a web page on the site, shouldn't we create the file under site/content/ directory structure? It is the source for the website, which is generated with hugo. It can be run locally as well

contour/Makefile

Lines 291 to 292 in 6a1ee75

site-devel: ## Launch the website
cd site && hugo serve

@izturn
Copy link
Member Author

izturn commented Aug 31, 2023

TBH, I am not sure where is the right place, put it here because of this @sunjayBhatia's comment: #5280 (comment), so I think the ECOSYSTEM.md should be the sibling of ADOPTERS.md, @sunjayBhatia any advice?

@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2023
@izturn
Copy link
Member Author

izturn commented Sep 21, 2023

ping @sunjayBhatia

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2023
@skriss
Copy link
Member

skriss commented Sep 22, 2023

Personally I would prefer having this page be on the website.

@sunjayBhatia
Copy link
Member

Yeah I think we maybe want to move/add the adopters file to the website, along with the ecosystem/integrations so they're both a bit more discoverable by search engines etc.

@izturn
Copy link
Member Author

izturn commented Sep 25, 2023

@tsaarni @skriss @sunjayBhatia PTAL

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploy preview pages:

With the current formatting, looks like the pages are being rendered as blog posts with an invalid date, we'll have to add something like this to the top of the page:

---
title: Compatibility Matrix
layout: page
---

also looks like the relative links to images in the adopters page no longer work (like

<a href="https://knative.dev" border="0" target="_blank"><img alt="knative.dev" src="site/img/adopters/knative.svg" height="50"></a>
)

It would be great to link these pages to each other and link them on the main index or at least in the table of contents of the site

Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn requested a review from sunjayBhatia September 26, 2023 03:42
@izturn izturn added area/website Issues or PRs related to the web site. and removed area/documentation Issues or PRs related to documentation. labels Sep 26, 2023
@izturn
Copy link
Member Author

izturn commented Sep 26, 2023

It would be great to link these pages to each other and link them on the main index or at least in the table of contents of the site

@sunjayBhatia, PTAL & pls tell me how to do it, thx

@izturn
Copy link
Member Author

izturn commented Oct 7, 2023

@sunjayBhatia ping

@izturn izturn self-assigned this Oct 18, 2023
@izturn izturn added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 18, 2023
Copy link

github-actions bot commented Nov 2, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2023
@izturn izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2023
@skriss
Copy link
Member

skriss commented Nov 2, 2023

I'd suggest adding the pages as "resources" under site/content/resources, and adding them to the table of contents in

- title: Resources
subfolderitems:
- page: Support Policy
link: /resources/support
- page: Compatibility Matrix
link: /resources/compatibility-matrix
- page: Contour Deprecation Policy
link: /resources/deprecation-policy
- page: Release Process
link: /resources/release-process
- page: Frequently Asked Questions
link: /resources/faq
- page: Tagging
link: /resources/tagging

site/content/ECOSYSTEM.md Outdated Show resolved Hide resolved
@izturn izturn requested a review from skriss November 3, 2023 02:14
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @izturn, LGTM

@sunjayBhatia sunjayBhatia merged commit eb71e5c into projectcontour:main Nov 6, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website Issues or PRs related to the web site. kind/feature Categorizes issue or PR as related to a new feature. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
Status: Done
4 participants