-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecosystem page #5537
Add ecosystem page #5537
Conversation
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5537 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 139 139
Lines 19614 19614
=======================================
Hits 15410 15410
Misses 3901 3901
Partials 303 303 |
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
ping |
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
ping |
i think so |
If aiming for a web page on the site, shouldn't we create the file under Lines 291 to 292 in 6a1ee75
|
TBH, I am not sure where is the right place, put it here because of this @sunjayBhatia's comment: #5280 (comment), so I think the |
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
ping @sunjayBhatia |
Personally I would prefer having this page be on the website. |
Yeah I think we maybe want to move/add the adopters file to the website, along with the ecosystem/integrations so they're both a bit more discoverable by search engines etc. |
Signed-off-by: gang.liu <gang.liu@daocloud.io>
@tsaarni @skriss @sunjayBhatia PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploy preview pages:
- https://deploy-preview-5537--projectcontour.netlify.app/adopters/
- https://deploy-preview-5537--projectcontour.netlify.app/ecosystem/
With the current formatting, looks like the pages are being rendered as blog posts with an invalid date, we'll have to add something like this to the top of the page:
contour/site/content/resources/compatibility-matrix.md
Lines 1 to 4 in 9ad7ac5
--- | |
title: Compatibility Matrix | |
layout: page | |
--- |
also looks like the relative links to images in the adopters page no longer work (like
Line 6 in 9ad7ac5
<a href="https://knative.dev" border="0" target="_blank"><img alt="knative.dev" src="site/img/adopters/knative.svg" height="50"></a> |
It would be great to link these pages to each other and link them on the main index or at least in the table of contents of the site
Signed-off-by: gang.liu <gang.liu@daocloud.io>
@sunjayBhatia, PTAL & pls tell me how to do it, thx |
@sunjayBhatia ping |
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
I'd suggest adding the pages as "resources" under contour/site/data/docs/main-toc.yml Lines 118 to 131 in 6cbb66c
|
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @izturn, LGTM
Signed-off-by: Gang Liu gang.liu@daocloud.io
fix #5280
fix #4704