Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-1.22: Cherry pick golang bump to 1.19.0 (#4660) #4692

Merged
merged 2 commits into from
Aug 29, 2022
Merged

release-1.22: Cherry pick golang bump to 1.19.0 (#4660) #4692

merged 2 commits into from
Aug 29, 2022

Conversation

sunjayBhatia
Copy link
Member

Signed-off-by: Sunjay Bhatia sunjayb@vmware.com

@sunjayBhatia
Bump golang to 1.19.0 (projectcontour#4660)
52a21b3 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Aug 29, 2022
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner August 29, 2022 16:56
@sunjayBhatia sunjayBhatia requested review from tsaarni and stevesloka and removed request for a team August 29, 2022 16:56
@skriss
Copy link
Member

skriss commented Aug 29, 2022

I guess we need #4661 and #4682 as well to get CI to be happy on this branch

@skriss
Copy link
Member

skriss commented Aug 29, 2022

#4695

@sunjayBhatia
Merge remote-tracking branch 'origin/release-1.22' into cherry-pick-1…
3530d04 
….22-golang-bump

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
skriss approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can likely ignore whatever CI failures we get at this point

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4692 (ede99fc) into release-1.22 (4eeb365) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ede99fc differs from pull request most recent head 3530d04. Consider uploading reports for the commit 3530d04 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##           release-1.22    #4692   +/-   ##
=============================================
  Coverage         75.95%   75.96%           
=============================================
  Files               140      140           
  Lines             13102    13102           
=============================================
+ Hits               9952     9953    +1     
+ Misses             2893     2892    -1     
  Partials            257      257
Impacted Files Coverage Δ
internal/sorter/sorter.go 98.79% <0.00%> (+0.60%) ⬆️

@skriss skriss merged commit 22fdabe into projectcontour:release-1.22 Aug 29, 2022
@sunjayBhatia sunjayBhatia deleted the cherry-pick-1.22-golang-bump branch August 29, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunjayBhatia @skriss