Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set Gateway status address from Envoy LB service #4236

Merged
merged 5 commits into from
Dec 16, 2021
Merged

set Gateway status address from Envoy LB service #4236

merged 5 commits into from
Dec 16, 2021

Conversation

skriss
Copy link
Member

@skriss skriss commented Dec 13, 2021

Sets the Gateway's status address from the
Envoy LoadBalancer service address, similarly
to how it's done for Ingress and HTTPProxy.

Closes #3828.

Signed-off-by: Steve Kriss krisss@vmware.com

@skriss skriss requested a review from a team as a code owner December 13, 2021 21:04
@skriss skriss requested review from tsaarni and stevesloka and removed request for a team December 13, 2021 21:04
@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021 •
edited
Loading

Codecov Report

Merging #4236 (c28ad89) into main (4b3f350) will increase coverage by 0.87%.
The diff coverage is 56.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4236      +/-   ##
==========================================
+ Coverage   76.85%   77.72%   +0.87%     
==========================================
  Files         114      112       -2     
  Lines       10084     9995      -89     
==========================================
+ Hits         7750     7769      +19     
+ Misses       2143     2041     -102     
+ Partials      191      185       -6
Impacted Files Coverage Δ
cmd/contour/ingressstatus.go 34.78% <0.00%> (-5.22%) ⬇️
cmd/contour/serve.go 11.92% <0.00%> (-0.10%) ⬇️
internal/k8s/statusaddress.go 78.87% <73.58%> (-3.15%) ⬇️
internal/gatewayapi/helpers.go 100.00% <100.00%> (ø)
...dership/mocks/need_leader_election_notification.go
internal/controller/mocks/manager.go

sunjayBhatia
sunjayBhatia approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@skriss
set Gateway status address from Envoy LB service
bf17d36 
Sets the Gateway's status address from the
Envoy LoadBalancer service address, similarly
to how it's done for Ingress and HTTPProxy.

Closes projectcontour#3828.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
changelog
f9f9e02 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
move go generate comment
406f26e 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
ignore mocks for codecov
b0a6e4f 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
add comments to test
c28ad89 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss merged commit 38adb69 into projectcontour:main Dec 16, 2021
@skriss skriss deleted the gwapi-set-address branch December 16, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@stevesloka stevesloka stevesloka approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@youngnick youngnick Awaiting requested review from youngnick

Assignees
No one assigned
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway API: set Gateway status address from Envoy LB service
3 participants
@skriss @stevesloka @sunjayBhatia