internal/xdscache: include global rate limits for secure vhosts #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a quick manual test on this and it seems to fix the issue but I'll do more thorough testing and add an integration test tomorrow. |
Codecov Report
@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
+ Coverage 75.39% 75.45% +0.06%
==========================================
Files 98 98
Lines 6588 6592 +4
==========================================
+ Hits 4967 4974 +7
+ Misses 1513 1510 -3
Partials 108 108
|
8aeae97 to
64a1937
Compare
|
400+ lines of tests for 6 lines of code :/ |
stevesloka
approved these changes
Feb 26, 2021
Fixes a bug where global rate limit policies were being ignored when defined at the virtual host level on secure vhosts. Fixes projectcontour#3409. Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
sunjayBhatia
approved these changes
Feb 26, 2021
skriss
added a commit
to skriss/contour
that referenced
this pull request
Mar 1, 2021
…ectcontour#3410) Fixes a bug where global rate limit policies were being ignored when defined at the virtual host level on secure vhosts. Fixes projectcontour#3409. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added a commit
that referenced
this pull request
Mar 1, 2021
* internal/xdscache: include global rate limits for secure vhosts (#3410) Fixes a bug where global rate limit policies were being ignored when defined at the virtual host level on secure vhosts. Fixes #3409. Signed-off-by: Steve Kriss <krisss@vmware.com> * cmd/contour: pass pointers to StatusAddressUpdater (#3412) Fixes an issue where non-pointers were being passed to the StatusAddressUpdater when the load balancer address changed, which was resulting in HTTPProxies/Ingresses not immediately getting updated with the new address. Fixes #3411. Signed-off-by: Steve Kriss <krisss@vmware.com> * examples: update Envoy to 1.17.1 (#3417) Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where global rate limit policies were being ignored
when defined at the virtual host level on secure vhosts.
Fixes #3409.
Signed-off-by: Steve Kriss krisss@vmware.com