Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support per_host_thresholds Envoy circuit breakers #6015

Closed
relu opened this issue Dec 14, 2023 · 0 comments · Fixed by #6016
Closed

Support per_host_thresholds Envoy circuit breakers #6015

relu opened this issue Dec 14, 2023 · 0 comments · Fixed by #6016
Assignees
@relu
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.28.0

Comments

@relu
Copy link
Contributor

relu commented Dec 14, 2023

Having the ability to set per-host circuit breaker thresholds would be very useful. At the moment, it is only possible to set cluster scoped thresholds.

Note that only max_connections are supported currently by envoy.

I would like to work on this feature addition.
@relu relu added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Dec 14, 2023
relu added a commit to relu/contour that referenced this issue Dec 14, 2023
@relu
internal/dag: Add support for per-host max connections
d13985a 
Support per-host max connections circuit breaker threshold enabling Envoy to
enforce a maximum number of connections for each individual Kubernetes service
endpoint using a new service-level annotation: `projectcontour.io/per-host-max-connections`.

Resolves projectcontour#6015

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu mentioned this issue Dec 14, 2023
Merged
relu added a commit to relu/contour that referenced this issue Dec 14, 2023
@relu
internal/dag: Add support for per-host max connections
cf85ee0 
Support per-host max connections circuit breaker threshold enabling Envoy to
enforce a maximum number of connections for each individual Kubernetes service
endpoint using a new service-level annotation: `projectcontour.io/per-host-max-connections`.

Resolves projectcontour#6015

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Jan 3, 2024
@skriss skriss added this to Contour Jan 3, 2024
@skriss skriss moved this to In Progress in Contour Jan 3, 2024
@skriss skriss added this to the 1.28.0 milestone Jan 3, 2024
@skriss skriss closed this as completed in c60a501 Jan 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Contour Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@relu relu

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: Done
Milestone
1.28.0
Development

Successfully merging a pull request may close this issue.

internal/dag: Add support for per-host max connections relu/contour
2 participants
@relu @skriss