Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document TLSCertificateDelegation NonSupport with Ingress/v1 #3546

Closed
stevesloka opened this issue Apr 6, 2021 · 0 comments · Fixed by #3551
Closed

Document TLSCertificateDelegation NonSupport with Ingress/v1 #3546

stevesloka opened this issue Apr 6, 2021 · 0 comments · Fixed by #3551
Labels
area/documentation Issues or PRs related to documentation.

Comments

@stevesloka
Copy link
Member

Ingress/v1 make some additional restrictions on the API validation to not allow forward slashes (/) in the secretName which breaks the functionality that Contour previously would allow with TLSCertificateDelegation.

We should document this limitation with IngressV1 & TLSCertDelegation.

Originally posted by @stevesloka in #3544 (comment)
@stevesloka stevesloka added the area/documentation Issues or PRs related to documentation. label Apr 6, 2021
@sunjayBhatia sunjayBhatia mentioned this issue Apr 6, 2021
Closed
sunjayBhatia added a commit to sunjayBhatia/contour that referenced this issue Apr 7, 2021
@sunjayBhatia
Ingress: Add detailed documentation
93c6b74 
Details which features we support, caveats, gotchas

Fixes: projectcontour#3546
Fixes: projectcontour#3469
Updates: projectcontour#3544

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia mentioned this issue Apr 7, 2021
Merged
stevesloka pushed a commit that referenced this issue Apr 9, 2021
@sunjayBhatia
Ingress: Add detailed documentation (#3551)
28ecf62 
* Ingress: Add detailed documentation

Details which features we support, caveats, gotchas

Fixes: #3546
Fixes: #3469
Updates: #3544

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation Issues or PRs related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ingress: Add detailed documentation sunjayBhatia/contour
1 participant
@stevesloka