This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Fix non-existent HTTPSRoute #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPSRoute does not exist as per [gateway API docs](https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.HTTPRoute). For HTTPS protocol, `HTTPRoute` + `spec.tls` needs to be used. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
sunjayBhatia
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Seems like we may need some more automated testing of example YAMLs cc @danehans
youngnick
approved these changes
Mar 1, 2021
stevesloka
approved these changes
Mar 1, 2021
skriss
pushed a commit
to skriss/contour-operator
that referenced
this pull request
Mar 1, 2021
HTTPSRoute does not exist as per [gateway API docs](https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.HTTPRoute). For HTTPS protocol, `HTTPRoute` + `spec.tls` needs to be used. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skriss
added a commit
that referenced
this pull request
Mar 1, 2021
HTTPSRoute does not exist as per [gateway API docs](https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.HTTPRoute). For HTTPS protocol, `HTTPRoute` + `spec.tls` needs to be used. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
|
xref: #211 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPSRoute does not exist as per gateway API docs.
For HTTPS protocol,
HTTPRoute+spec.tlsneeds to be used.Signed-off-by: Kenjiro Nakayama nakayamakenjiro@gmail.com
/cc @danehans