Feature/add mandatory asterisk #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
approved these changes
Jan 6, 2025
|
@anehx do you want to take a look at this one as well? |
anehx
requested changes
Jan 6, 2025
packages/form/tests/integration/components/cf-field/label-test.js
Outdated
Show resolved
Hide resolved
packages/form/tests/integration/components/cf-field/label-test.js
Outdated
Show resolved
Hide resolved
packages/form/tests/integration/components/cf-field/label-test.js
Outdated
Show resolved
Hide resolved
|
Also what I forgot in my review: We test if it works when that option is passed directly to the component which is very unlikely to happen but not whether the actual configuration of that feature using |
anehx
requested changes
Jan 7, 2025
packages/form/tests/integration/components/cf-field/label-test.js
Outdated
Show resolved
Hide resolved
anehx
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added mandatory asterisk configuration option for labels of form questions