Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add optional peer dep on ember data #2622

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: add optional peer dep on ember data #2622

merged 1 commit into from
Mar 6, 2024

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Jan 30, 2024

Without this, the dependencyStatisfies embroider macro won't work -
see embroider-build/embroider#1169 (comment)
for details.

@czosel czosel force-pushed the ember-data-peer-dep branch from 751e04f to b2684fe Compare January 30, 2024 13:56
@czosel czosel requested review from anehx and StephanH90 January 30, 2024 13:56
@czosel czosel force-pushed the ember-data-peer-dep branch from b2684fe to bc03f54 Compare January 30, 2024 14:01
@czosel czosel force-pushed the ember-data-peer-dep branch from bc03f54 to cfa2470 Compare January 30, 2024 14:56
@anehx anehx force-pushed the ember-data-peer-dep branch 2 times, most recently from 9809377 to 8416756 Compare March 4, 2024 08:16
Without this, the `dependencyStatisfies` embroider macro won't work -
see embroider-build/embroider#1169 (comment)
for details.
@anehx anehx force-pushed the ember-data-peer-dep branch from 8416756 to 5a63527 Compare March 6, 2024 12:03
@anehx anehx merged commit 033cb84 into main Mar 6, 2024
57 checks passed
@anehx anehx deleted the ember-data-peer-dep branch March 6, 2024 12:22
@anehx
Copy link
Contributor

anehx commented Mar 6, 2024

🎉 This PR is included in version 12.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anehx anehx added the released label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants