feat(form-builder): allow editing of form meta #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anehx
requested changes
Jan 3, 2024
packages/form-builder/addon/components/cfb-form-editor/show-advanced-btn.hbs
Outdated
Show resolved
Hide resolved
6092c32 to
d3481e4
Compare
|
Not sure why the pipeline fails because it works for me locally: pnpm --filter @projectcaluma/ember-form exec ember try:one ember-lts-4.8 --skip-cleanup
1..160
# tests 160
# pass 152
# skip 8
# todo 0
# fail 0
# ok |
Flaky test: #2514 |
d3481e4 to
cdeda14
Compare
anehx
approved these changes
Jan 9, 2024
|
🎉 This PR is included in version 12.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows editing of form meta (similar to the question meta).