feat(check-question): add reset button for optional question #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabauke
approved these changes
Dec 7, 2023
anehx
reviewed
Dec 7, 2023
czosel
reviewed
Dec 11, 2023
packages/form/tests/integration/components/cf-field/input/radio-test.js
Outdated
Show resolved
Hide resolved
czosel
reviewed
Dec 11, 2023
97fb5cc to
3ba0248
Compare
3ba0248 to
41404a7
Compare
anehx
requested changes
Dec 19, 2023
|
@derrabauke You forgot to push.. There are no changes after my review. |
Not forgotten, but I was tangled in confusion how the |
f87a06f to
a168022
Compare
anehx
reviewed
Dec 19, 2023
|
Alright, one final nitpick then it is ready to go 🎉 Sorry @derrabauke 😉 |
anehx
approved these changes
Dec 19, 2023
|
🎉 This PR is included in version 12.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a reset button after non-required inputs of a
choicequestion type.Preview