feat(copy): drag-drop shift modifier to move/copy a document #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anehx
requested changes
Feb 12, 2025
addon/components/document-view.js
Outdated
Comment on lines
39
to
41
| get canDropCopy() { | ||
| return Boolean( | ||
| this.dragAction === "copy" && | ||
| this.args.filters && | ||
| this.args.filters.categories, | ||
| ); | ||
| } | ||
|
|
||
| get canDropUpload() { | ||
| return Boolean( | ||
| this.dragAction === "upload" && | ||
| this.args.filters && | ||
| this.args.filters.categories, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Why do you need to distinguish these two? Couldn't you just do something like this?
Suggested change
| get canDropCopy() { | |
| return Boolean( | |
| this.dragAction === "copy" && | |
| this.args.filters && | |
| this.args.filters.categories, | |
| ); | |
| } | |
| get canDropUpload() { | |
| return Boolean( | |
| this.dragAction === "upload" && | |
| this.args.filters && | |
| this.args.filters.categories, | |
| ); | |
| } | |
| get canDrop() { | |
| return Boolean( | |
| ["copy", "upload"].includes(this.dragAction) && | |
| this.args.filters && | |
| this.args.filters.categories, | |
| ); | |
| } |
There was a problem hiding this comment.
For the component purpose it could be simplified but in the template I'm depending on separate methods to differentiate between two different translations. See document-view.hbs
There was a problem hiding this comment.
I think differentiating by this.dragAction in the template would be the way to go for this.
333562d to
118cffb
Compare
|
@anehx rebased and added some fixes and comments |
anehx
requested changes
Feb 17, 2025
addon/components/document-view.hbs
Outdated
| @@ -7,8 +7,7 @@ | |||
| > | |||
| <div class="uk-flex uk-flex-middle uk-padding-small"> | |||
| <DocumentUploadButton | |||
| @categoryId={{@filters.categories}} | |||
| @afterUpload={{this.refreshDocumentList}} | |||
| @categoryId={{@filters.categories}} @afterUpload={{this.refreshDocumentList}} | |||
There was a problem hiding this comment.
Let's revert this formatting change.
addon/components/document-view.js
Outdated
Comment on lines
39
to
41
| get canDropCopy() { | ||
| return Boolean( | ||
| this.dragAction === "copy" && | ||
| this.args.filters && | ||
| this.args.filters.categories, | ||
| ); | ||
| } | ||
|
|
||
| get canDropUpload() { | ||
| return Boolean( | ||
| this.dragAction === "upload" && | ||
| this.args.filters && | ||
| this.args.filters.categories, | ||
| ); | ||
| } |
There was a problem hiding this comment.
I think differentiating by this.dragAction in the template would be the way to go for this.
118cffb to
d385a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new feature to allow copying documents together with the underlying files.
While holding shift you can either drag the document(s) onto the document view (to copy within the same category), or onto a category by dropping it onto the category navigation on the left.
This functionality will rely on projectcaluma/alexandria#757