chore(release): bump version #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-dynaMIX
requested changes
Dec 9, 2022
|
We are using the "newer" filter syntax. I mean its pretty far fetched since nobody is using such an old caluma version anyway (I hope?)
…--
Adfinis AG
Stephan Hug, Software Engineer, GPG Key: C831A3A24D5719BA619604E622CD5AB4CFECD397
Giessereiweg 5 | CH-3007 Berne
Office +41 31 550 31 11 | Direct +41 31 550 31 02
www.adfinis.com
-----Original message-----
From: Fabio ***@***.***>
Sent: Friday 9th December 2022 11:03
To: projectcaluma/caluma-interval ***@***.***>
Cc: Stephan Hug ***@***.***>; Author ***@***.***>
Subject: Re: [projectcaluma/caluma-interval] chore(release): bump version (PR #370)
@open-dynaMIX requested changes on this pull request.
Why is this a major version bump? Should be 2.0.1, right?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Ah, I see. Then it would be good to add this info to the changelog. |
|
I wanted to, but I was looking at the changelog of caluma and I couldn't find when it was changed. I went as far back as v5. So I wasn't sure if it was worth the effort to dig further.
Perhaps we can just write something like: "requires Caluma > v5" or similar.
…--
Adfinis AG
Stephan Hug, Software Engineer, GPG Key: C831A3A24D5719BA619604E622CD5AB4CFECD397
Giessereiweg 5 | CH-3007 Berne
Office +41 31 550 31 11 | Direct +41 31 550 31 02
www.adfinis.com
-----Original message-----
From: Fabio ***@***.***>
Sent: Friday 9th December 2022 11:20
To: projectcaluma/caluma-interval ***@***.***>
Cc: Stephan Hug ***@***.***>; Author ***@***.***>
Subject: Re: [projectcaluma/caluma-interval] chore(release): bump version (PR #370)
Ah, I see. Then it would be good to add this info to the changelog.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I guess its very safe to assume that nobody in the world is using Caluma < v3 anymore, so can we merge this? |
open-dynaMIX
approved these changes
Jan 27, 2023
0f96c5d to
d907a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.