[BPF] Automatically adjust to actual max-entries when dumping conntra…

[ioworker0]

Description

Previously, the conntrack map size would not dynamically adjust to the default value when dumping the conntrack map, even if the global Felix configuration was modified or the BPFMapSizeConntrackPerCPU feature (which is supposed to scale the map size based on the number of CPU cores) was enabled.

So, let's do some things to address this issue ~

Related issues/PRs

fixes #9651

Todos

• Tests
• Documentation
• Release note

Release Note

ebpf: adjust the default value to the value from the actual map when dumping the conntrack map in calico-bpf

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

• docs-pr-required: This change requires a change to the documentation that has not been completed yet.
• docs-completed: This change has all necessary documentation completed.
• docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

• release-note-required: This PR has user-facing changes. Most PRs should have this label.
• release-note-not-required: This PR has no user-facing changes.

Other optional labels:

• cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
• needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

[ioworker0]

@tomastigera

[tomastigera]

/sem-approve

[tomastigera]

LGTM, some nits/tweaks, thanks

[ioworker0]

LGTM, some nits/tweaks, thanks

Thanks a lot for taking time to review!

[ioworker0]

LGTM, some nits/tweaks, thanks

Done ~

[tomastigera]

LGTM, thanks

[tomastigera]

/sem-approve

[ioworker0]

/sem-approve

Oops ;(

We've added a ver flag to commands, so we longer need docopt to parse it.

[tomastigera]

/sem-approve

[tomastigera]

There seems to be some issue with creating --ver=2 map, it breaks one test, see https://tigera.semaphoreci.com/jobs/9660d5a8-3f05-44a8-842c-1363d5fba628/artifacts/test-7.log

You can run the test locally from calico/felix directory by invoking make fv-bpf GINKGO_FOCUS="Felix bpf test conntrack map upgrade.*should upgrade conntrack entries from v2 to v3" 2>&1 | tee fv.log

• Failure [4.449 seconds]
_BPF-SAFE_ Felix bpf test conntrack map upgrade (etcdv3 backend)
/go/src/github.com/projectcalico/calico/felix/fv/infrastructure/datastore_describe.go:40
  should upgrade conntrack entries from v2 to v3 [It]
  /go/src/github.com/projectcalico/calico/felix/fv/bpf_map_upgrade_test.go:63

  Command failed
  Command: docker args: [exec felix-0-35797-477-felixfv calico-bpf conntrack create --ver=2]
  Output:
  
  time="2025-01-16T21:21:32Z" level=fatal msg="Failed to get ConntrackMap" func="github.com/projectcalico/calico/felix/cmd/calico-bpf/commands.(*conntrackCreateCmd).Run" file="/go/src/github.com/projectcalico/calico/felix/cmd/calico-bpf/commands/conntrack.go:470" error="failed to access conntrack Map"
  

[ioworker0]

Sorry for the late response, I was tied up with work ;(

There seems to be some issue with creating --ver=2 map, it breaks one test, see https://tigera.semaphoreci.com/jobs/9660d5a8-3f05-44a8-842c-1363d5fba628/artifacts/test-7.log

You can run the test locally from calico/felix directory by invoking make fv-bpf GINKGO_FOCUS="Felix bpf test conntrack map upgrade.*should upgrade conntrack entries from v2 to v3" 2>&1 | tee fv.log

Ah, I see~

The mistake I made was thinking that the logic for creating a new conntrack map required adding a new step to adjust the size. But, this change broke one of the tests.

So, to fix this, let's revert to the original behavior.

• Failure [4.449 seconds]
_BPF-SAFE_ Felix bpf test conntrack map upgrade (etcdv3 backend)
/go/src/github.com/projectcalico/calico/felix/fv/infrastructure/datastore_describe.go:40
  should upgrade conntrack entries from v2 to v3 [It]
  /go/src/github.com/projectcalico/calico/felix/fv/bpf_map_upgrade_test.go:63

  Command failed
  Command: docker args: [exec felix-0-35797-477-felixfv calico-bpf conntrack create --ver=2]
  Output:
  
  time="2025-01-16T21:21:32Z" level=fatal msg="Failed to get ConntrackMap" func="github.com/projectcalico/calico/felix/cmd/calico-bpf/commands.(*conntrackCreateCmd).Run" file="/go/src/github.com/projectcalico/calico/felix/cmd/calico-bpf/commands/conntrack.go:470" error="failed to access conntrack Map"
  

It has now passed locally with the new commit ;)

Thanks again for your help!

[tomastigera]

/sem-approve

[ioworker0]

/sem-approve

Is seems like just a flake with a 404 status code occurred.

Would you please re-run the CI?

[tomastigera]

/sem-approve