Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loose option to BPFEnforceRPF option #7094

Closed
wants to merge 45 commits into from
Closed

Add Loose option to BPFEnforceRPF option #7094

wants to merge 45 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2022

Add Loose option to BPFEnforceRPF Felix configuration property to relax Reverse Path Filtering [RPF] for host endpoints only. Note: Calico always enforces Strict option for workloads on pods as before.

Description

Related issues/PRs

#7008

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: BPFEnforceRPF has Loose option

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@ghost ghost self-requested a review as a code owner December 15, 2022 09:34
@marvin-tigera marvin-tigera added this to the Calico v3.25.0 milestone Dec 15, 2022
@marvin-tigera marvin-tigera added docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels Dec 15, 2022
Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits, and we should beef up the test.

felix/fv/rpf_test.go Show resolved Hide resolved
felix/bpf-gpl/globals.h Show resolved Hide resolved
felix/bpf-gpl/rpf.h Show resolved Hide resolved
felix/bpf/tc/attach.go Show resolved Hide resolved
felix/dataplane/linux/bpf_ep_mgr.go Outdated Show resolved Hide resolved
@tomastigera tomastigera changed the title DRAFT WIP BPF-2090 Add Loose option to BPFEnforceRPF option Add Loose option to BPFEnforceRPF option Dec 30, 2022
Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits

calico/reference/felix/configuration.md Outdated Show resolved Hide resolved
felix/fv/rpf_test.go Show resolved Hide resolved
api/pkg/apis/projectcalico/v3/felixconfig.go Outdated Show resolved Hide resolved
@ghost ghost mentioned this pull request Jan 3, 2023
3 tasks
@tomastigera
Copy link
Contributor

closing in favour of #7138

@tomastigera tomastigera closed this Jan 3, 2023
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jan 3, 2023
@ghost ghost deleted the BPF-2090_BPFEnforceRPF_Loose_Option branch January 6, 2023 10:40
@ghost ghost mentioned this pull request Jan 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants