Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet suggest: filtering facets, choosing a value, then attempting to filter again does not work #3507

Closed
sandbergja opened this issue Feb 5, 2025 · 1 comment
Assignees

Comments

@sandbergja
Copy link
Contributor

Steps to recreate locally on the release-8.x branch:

  1. Follow these steps to set up blacklight locally
  2. Edit the subject facet field configuration to the following in .internal_test_app/app/controllers/catalog_controller.rb:
    config.add_facet_field 'subject_ssim', label: 'Topic', limit: 3, index_range: 'A'..'Z', suggest: true
    
  3. In .internal_test_app, run bundle exec rails s
  4. In your browser, go to http://localhost:3000
  5. In the topic facet, click the "More >>" link
  6. Type "dr" and select Japanese Drama
  7. Note that the URL contains only_values=true and query_fragment=dr
  8. In the topic facet, click the "More >>" link again
  9. Note that the modal is not usable, with no facet values, not even an "X" to dismiss the modal! 😞

Here is what the modal looks like for me:

A very small modal says Japanese drama, has an x, and then the number 2

Removing only_values=true and query_fragment=dr from the URL fixes it for me. I believe that the links in the facet modal should not include those parameters.

@maxkadel
Copy link
Contributor

maxkadel commented Feb 6, 2025

Closed by #3509

@maxkadel maxkadel closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants