Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: spec plan of tgdump with any SQL statements. #44

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

ashigeru
Copy link
Contributor

This PR proposes a design that introduces the --sql option to the tgdump command to allow dump processing by any SQL statement.
Note that only the documentation will be changed at this time, and implementation will be done later if this proposal is accepted.

@ashigeru ashigeru requested a review from akirakw December 26, 2024 08:37
@ashigeru ashigeru requested a review from hishidama as a code owner December 26, 2024 08:37
@ashigeru ashigeru self-assigned this Dec 26, 2024
@ashigeru ashigeru changed the title docs: spec plan of tgdump with any SQL statements. doc: spec plan of tgdump with any SQL statements. Jan 5, 2025
@ashigeru ashigeru changed the title doc: spec plan of tgdump with any SQL statements. docs: spec plan of tgdump with any SQL statements. Jan 5, 2025
Copy link
Contributor

@akirakw akirakw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
However, the handling of --sql and <query-label> is a bit complicated, so it would be better to provide command examples.

Copy link
Contributor

@hishidama hishidama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題無いと思います。

(ドキュメントに書くことではないと思いますが、実際の使い方は --sql "sql1: select ~" のようにコロンの前後に空白が入ることが予想されるので、それが許容されるのであれば問題ないと思います)

@ashigeru
Copy link
Contributor Author

ashigeru commented Jan 6, 2025

@akirakw #44 (review)

LGTM. However, the handling of --sql and <query-label> is a bit complicated, so it would be better to provide command examples.

We plan to revise it later with another PR.

@ashigeru ashigeru merged commit 5c0dc50 into master Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants