-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance "--insecure" option for stacker builds #311
Comments
stacker already supports a insecure should mean:
Also, does this have to be a build arg on cmdline or in the stacker.yaml, or both?
|
Also, |
That is a lot of things for one flag. I would also like to request that we avoid negative terms. Ie, i'd rather have the keyword 'secure' and it default to 'true' than 'insecure' and it default to 'false'. doulbe negatives just cause confusion. |
BREAKING CHANGE: `insecure:` directive is now `true` by default. Previously, it was `false`. Fixes issue project-stacker#311 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
BREAKING CHANGE: `insecure:` directive is now `true` by default. Previously, it was `false`. Fixes issue project-stacker#311 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Add a
stacker build --insecure
so that when the build encounters afrom:
remote url, the build will proceed only if from signed/trusted sources. NOTE that insecure mode is currently the default, but we should move to secure by default and make insecure explicit.The following options must be supported.
References:
docker trust inspect alpine:edge
https://github.com/docker/cli/blob/master/cli/command/trust/inspect.go#L22
https://github.com/sigstore/cosign
https://github.com/notaryproject/notation
The text was updated successfully, but these errors were encountered: