Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add musl-tools #879

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Add musl-tools #879

merged 1 commit into from
Apr 20, 2020

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Apr 20, 2020 •
edited
Loading

This change adds musl-tools package to the Dockerfile.
musl-tools contains musl-gcc that is necessary to compile ring (that is a rustls dependency) with a --target=x86_64-unknown-linux-musl flag.

Checklist

  • Pull request includes prototype/experimental work that is under
    construction.

@ipetr0v ipetr0v requested a review from tiziano88 April 20, 2020 18:19
tiziano88
tiziano88 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@tiziano88 tiziano88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run ./scripts/docker_push just before or just after merging.

@ipetr0v ipetr0v merged commit 37efedd into project-oak:master Apr 20, 2020
@ipetr0v ipetr0v deleted the musl_gcc branch April 20, 2020 19:06
@ipetr0v ipetr0v mentioned this pull request Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipetr0v @tiziano88 @googlebot