Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable rustfmt example in scripts/build_examples #660

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Disable rustfmt example in scripts/build_examples #660

merged 1 commit into from
Mar 2, 2020

Conversation

blaxill
Copy link
Contributor

@blaxill blaxill commented Feb 28, 2020 •
edited
Loading

Example rustfmt was disabled in run_examples and run_tests in #588. It seems build_examples has been broken since then (e.g. CI uses run_examples which doesn't use build_examples).

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@daviddrysdale
Copy link
Contributor

Passing to @ipetr0v as he's working with scripts atm (#649)

@daviddrysdale daviddrysdale removed their request for review February 28, 2020 16:06
@blaxill blaxill merged commit 40560fe into project-oak:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipetr0v ipetr0v ipetr0v approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blaxill @daviddrysdale @ipetr0v @googlebot