Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust version #588

Merged
merged 8 commits into from
Feb 11, 2020
Merged

Update Rust version #588

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
00f9cf1
Update rust
blaxill Feb 10, 2020
65fa3f7
Clippy fixes
blaxill Feb 10, 2020
f582cf7
Clippy fixes
blaxill Feb 10, 2020
5c4cbbb
Workspace
blaxill Feb 10, 2020
4cfe51b
Update dependencies
blaxill Feb 10, 2020
d0aedc1
Disable rustfmt example
blaxill Feb 10, 2020
5184c82
Add TODO(#594)
blaxill Feb 11, 2020
76581f8
Add Dockerfile & WORKSPACE comments
blaxill Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ RUN chmod a+rwx ${RUSTUP_DIR}

# Install Rust toolchain.
# We currently need the nightly version in order to be able to compile some of the examples.
ARG RUST_VERSION=nightly-2019-07-18
# See https://rust-lang.github.io/rustup-components-history/ for how to pick a version that supports
# the appropriate set of components.
ARG RUST_VERSION=nightly-2020-02-06
RUN rustup toolchain install ${RUST_VERSION}
RUN rustup default ${RUST_VERSION}

Expand Down
2 changes: 1 addition & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ rust_repository_set(
name = "rust_linux_x86_64",
exec_triple = "x86_64-unknown-linux-gnu",
extra_target_triples = [],
iso_date = "2019-11-06",
iso_date = "2020-02-06",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here and in the Dockerfile to make sure these values are kept in sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

version = "nightly",
)

Expand Down
Loading