Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift to using stable Rust #1036

Closed
wants to merge 3 commits into from
Closed

Shift to using stable Rust #1036

wants to merge 3 commits into from

Conversation

daviddrysdale
Copy link
Contributor

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@daviddrysdale daviddrysdale added the WIP Work in progress label May 27, 2020
@daviddrysdale daviddrysdale changed the title Stable Shift to using stable Rust May 27, 2020
This was referenced May 27, 2020
Closed
Closed
tiziano88
tiziano88 reviewed Jun 4, 2020
View reviewed changes
Dockerfile Outdated
# the appropriate set of components.
# Make sure to update WORKSPACE too, e.g. when updating nightly version
ARG rust_version=nightly-2020-04-17
ARG rust_version=stable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that stable does not uniquely identify a version, I guess this should be something like 1.43.1

@jul-sh jul-sh changed the base branch from master to main June 16, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 left review comments

Assignees
No one assigned
Labels
cla: yes WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviddrysdale @tiziano88 @googlebot