-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make oak_abi a standalone crate #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought about the abi
name: it pretty much guarantees that we won't be able to publish this crate to crates.io without doing another rename. Are we happy with that?
(Please wait on @tiziano88's review, as he understands crate resolution etc. rather better than I do.)
will take a look shortly, but yes, crates live in a global namespace, so |
Aside: |
I changed the name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I think having "fix #xxx" in the commit message will cause the issue to be marked as fixed. If that's not the intention, use "ref #xxx" or just "#xxx".
@@ -37,7 +36,6 @@ members = [ | |||
[patch.crates-io] | |||
# Oak. | |||
oak = { path = "sdk/rust/oak" } | |||
oak_abi = { path = "oak/server/rust/oak_abi" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep this and just redirect it to the new location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! This works! Thanks.
Reproducibility Index:
Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 0917b73..3589647 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,10 +1,10 @@
-fad788689ce720de602a0ac0a283841e18ed732dc8bd3a49b248371ef679091d ./target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
-309920b1a713aeccef1ef2d86b6dd7fcec0f546b64481b9d0249c0a50025b3da ./target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
-bc5069ef4a2ee4290dc9c27bf76121b189a4688eceb3d21851bc3301af6cfc93 ./target/wasm32-unknown-unknown/release/aggregator.wasm
-8d26c5c254734431b3d9989ed6cd35098d29bc4030ab06acf9cb778f7ea19466 ./target/wasm32-unknown-unknown/release/chat.wasm
-66bfa58c5d81ed3e5789fbd8e81a9dd1010fb3493898c0cf74e300892f54d4cb ./target/wasm32-unknown-unknown/release/hello_world.wasm
-b0fd14f5f3bf92e1e3f87f81673c75231891fd94844423ca7bd1406ac0b67a77 ./target/wasm32-unknown-unknown/release/machine_learning.wasm
-56dc8b22013c1407d54796970d68c679e9527c796e983facce58716811c94567 ./target/wasm32-unknown-unknown/release/private_set_intersection.wasm
-63b2e0cc081afc32b832270b7b51dde15283e3359f25b6405b03beca65814ae5 ./target/wasm32-unknown-unknown/release/running_average.wasm
-27d2e5e653229e89fea8610c61434957e999e409a995528fd67a7679618c3e8d ./target/wasm32-unknown-unknown/release/translator.wasm
-cad49b83df868bd7ed6b4bb42554c88f79b8eeda4f9202e6c89f127db26314e0 ./target/x86_64-unknown-linux-musl/release/oak_loader
+7a37a36914d06fb1e794e34f79d1b3b03aa990df63648d476fc50dbebe253204 ./target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
+e93ed85acf99f770082881ff78bcc30e1115876ecaadb1fe34424c9e1b790b35 ./target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
+7b86363b5862c55e6ed72b17f3a800cea4b8b92e80223b12c755d09739507455 ./target/wasm32-unknown-unknown/release/aggregator.wasm
+d4cde436a03e0cd60bd79fc6e785ee54136a529dbbde2e8f431530496c57465a ./target/wasm32-unknown-unknown/release/chat.wasm
+d912c507830331ed8acd8a110728dadc980ee3a8490436379bb54782d51eda9c ./target/wasm32-unknown-unknown/release/hello_world.wasm
+9683350f1625b63aa0c3572686d500d6b04dc09e8b4b74b67d1a66d5416954ff ./target/wasm32-unknown-unknown/release/machine_learning.wasm
+87450eb3047b4af18a3d97a5479265946c088f0e6dc15b5d9059db84e6e67704 ./target/wasm32-unknown-unknown/release/private_set_intersection.wasm
+1fb4b737d8601b83f452f14ea0d5820a4f6cbe359f767520d0952dd7d42246f1 ./target/wasm32-unknown-unknown/release/running_average.wasm
+3966da34c20d72f2d00f5b3aedd0c81c2fa93daf0bbbeed62ccc702c2447a8e2 ./target/wasm32-unknown-unknown/release/translator.wasm
+7440ad23fba92dc450240d830dd3f322c8ace606eef86eededbccda859d1d67d ./target/x86_64-unknown-linux-musl/release/oak_loader
|
Ref #971
Checklist
cover any TODOs and/or unfinished work.
construction.