Prepare for PNC Jakarta versions (needed by Quarkus 3) #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=============================================
- Coverage 68.55% 53.76% -14.79%
- Complexity 629 674 +45
=============================================
Files 39 51 +12
Lines 3101 4112 +1011
Branches 379 523 +144
=============================================
+ Hits 2126 2211 +85
- Misses 801 1657 +856
- Partials 174 244 +70 ☔ View full report in Codecov by Sentry. |
janinko
reviewed
Nov 7, 2024
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>resteasy-client</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Do you need these two among the dependencies? isn't it enough that it's in dependency management?
There was a problem hiding this comment.
No, because these are excluded on line 397.
There was a problem hiding this comment.
I had to revert the jakarta versions, because it breaks the CLI. I will commit part of this patch though.
48ce92b to
87f0688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.