Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no.json #440

Merged
merged 4 commits into from
Dec 25, 2021
Merged

Update no.json #440

merged 4 commits into from
Dec 25, 2021

Conversation

0pax
Copy link
Contributor

@0pax 0pax commented Dec 24, 2021

Pull Request Description

Added missing translations for the phone in Norwegian Bokmål. Let me know if there's any mistakes @itschip
Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct? Yes
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change? Yes
  • Have you built and tested NPWD in-game after the relevant change? Yes

Added missing translations.
@TasoOneAsia TasoOneAsia requested a review from itschip December 24, 2021 22:42
@TasoOneAsia TasoOneAsia added the Translation Pull Request adds translation. label Dec 24, 2021
phone/src/locale/no.json Outdated Show resolved Hide resolved
phone/src/locale/no.json Outdated Show resolved Hide resolved
phone/src/locale/no.json Outdated Show resolved Hide resolved
phone/src/locale/no.json Outdated Show resolved Hide resolved
@itschip
Copy link
Member

itschip commented Dec 24, 2021

Please go over the Pull Request Checklist as well :)

@0pax
Copy link
Contributor Author

0pax commented Dec 24, 2021

@itschip everything is good, just forgot to check it when submitting the PR (thats why it says Yes after)

@itschip itschip self-requested a review December 24, 2021 23:02
@itschip itschip added the To be merged Tested and ready for merge label Dec 24, 2021
@itschip itschip merged commit b6cb2e4 into project-error:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To be merged Tested and ready for merge Translation Pull Request adds translation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants