Stop relying on the input .zap file in Matter test codegen. #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep backwards compat with old Matter revisions, we require explicit includeAllClusters=true in the templates to get the new behavior.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 19, 2023
Depends on project-chip/zap#1035 to actually ignore that state.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 19, 2023
Depends on project-chip/zap#1035 to actually ignore that state.
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
- Coverage 67.04% 67.03% -0.01%
==========================================
Files 157 157
Lines 17198 17202 +4
Branches 3756 3760 +4
==========================================
+ Hits 11531 11532 +1
- Misses 5667 5670 +3
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 19, 2023
Depends on project-chip/zap#1035 to actually ignore that state.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 20, 2023
Depends on project-chip/zap#1035 to actually ignore that state.
andy31415
approved these changes
May 20, 2023
brdandu
approved these changes
May 22, 2023
Our latest "application templates" (as in, the test codegen) would be setting |
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 22, 2023
Depends on project-chip/zap#1035 to actually ignore that state.
yufengwangca
pushed a commit
to project-chip/connectedhomeip
that referenced
this pull request
May 23, 2023
…26703) Depends on project-chip/zap#1035 to actually ignore that state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep backwards compat with old Matter revisions, we require explicit includeAllClusters=true in the templates to get the new behavior.