Fix a race in CHIPDeviceController while shutting down #8803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CHIPDeviceController can accept new jobs on its workqueue even though a "shutdown" is queued up. Because of this each Job has to make sure it checks the
isRunning
state of the controller before performing any tasks.This is an unfortunate side-effect of not knowing whether or not a Shutdown has occurred since the current Job was queued up.
Change overview
Make sure to check
isRunning
while callinggetConnectedDevice
Testing
How was this tested? (at least one bullet point required)
Since this was a race it is not straightforward to write a deterministic test.
Ran the Controller lifecycle tests a few 100x. It doesn't flake anymore.