-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Introduce GetClusterInfoById #8749
Merged
andy31415
merged 2 commits into
project-chip:master
from
erjiaqing:python/cluster-id-mapping
Aug 5, 2021
Merged
[python] Introduce GetClusterInfoById #8749
andy31415
merged 2 commits into
project-chip:master
from
erjiaqing:python/cluster-id-mapping
Aug 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
approved these changes
Aug 2, 2021
bzbarsky-apple
approved these changes
Aug 2, 2021
fae46a8
to
f3b8da1
Compare
Could you separate out the 'generate file' from the rest of the commits to make code review easier? |
andy31415
approved these changes
Aug 3, 2021
trombadore-google
approved these changes
Aug 3, 2021
45c2ffc
to
03aa0c4
Compare
jmartinez-silabs
approved these changes
Aug 4, 2021
@erjiaqing - merge conflicts |
03aa0c4
to
b0a4c02
Compare
Size increase report for "esp32-example-build" from 99ef92e
Full report output
|
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [python] Introduce GetClusterInfoById * Run Codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Testing
test.TestPythonAPI(self)
to test this API.