Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CHIP_ERROR a class type on k32w, mbed, telink #8745

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue #8340).

Change overview

  • Enable CHIP_CONFIG_ERROR_CLASS on k32w, mbed, and telink.

Testing

Existing tests should confirm no change to functionality.

#### Problem

Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue project-chip#8340).

#### Change overview

- Enable `CHIP_CONFIG_ERROR_CLASS` on k32w, mbed, and telink.

#### Testing

Existing tests should confirm no change to functionality.
@github-actions
Copy link

Size increase report for "esp32-example-build" from e175721

File Section File VM
chip-lock-app.elf .flash.text -64 -64
chip-ipv6only-app.elf .flash.text 172 172
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,172,172
[Unmapped],0,-172

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit 9ca9d47 into project-chip:master Aug 3, 2021
@kpschoedel kpschoedel deleted the x8340-error-class-5 branch August 3, 2021 13:59
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
#### Problem

Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue project-chip#8340).

#### Change overview

- Enable `CHIP_CONFIG_ERROR_CLASS` on k32w, mbed, and telink.

#### Testing

Existing tests should confirm no change to functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants