-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing FixedSpan to TLVWriter::Put. #8294
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-span-facilities
Jul 14, 2021
Merged
Allow passing FixedSpan to TLVWriter::Put. #8294
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-span-facilities
Jul 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Jul 12, 2021
Size increase report for "esp32-example-build" from 47823f1
Full report output
|
Damian-Nordic
approved these changes
Jul 13, 2021
Two main changes here: 1. Narrow down the existing Put template for enums to only get matched for enum types, so it does not try to get compiled for a FixedSpan. 2. Introduce more inter-conversions between Span and FixedSpan, where possible, via implicit constructors.
2bb9d1f
to
61114e0
Compare
@jmartinez-silabs @LuDuda @jepenven-silabs @msandstedt @saurabhst please take a look? |
jmartinez-silabs
approved these changes
Jul 13, 2021
msandstedt
approved these changes
Jul 13, 2021
tcarmelveilleux
approved these changes
Jul 13, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Two main changes here: 1. Narrow down the existing Put template for enums to only get matched for enum types, so it does not try to get compiled for a FixedSpan. 2. Introduce more inter-conversions between Span and FixedSpan, where possible, via implicit constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes here:
Narrow down the existing Put template for enums to only get matched
for enum types, so it does not try to get compiled for a FixedSpan.
Introduce more inter-conversions between Span and FixedSpan, where
possible, via implicit constructors.
Problem
Can't
Put
aFixedSpan
, so people hand-write thedata()
andsize()
bits.Change overview
See above.
Testing
Passes unit tests, and I can now pass a
FixedSpan
toTLVWriter::Put
(in a different PR).